lkml.org 
[lkml]   [2010]   [Sep]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/2] PM: Fix potential issue with failing asynchronous suspend
    On Mon, Sep 20, 2010 at 08:00:44PM +0200, Rafael J. Wysocki wrote:
    > From: Rafael J. Wysocki <rjw@sisk.pl>
    > Subject: PM: Fix potential issue with failing asynchronous suspend
    >
    > There is a potential issue with the asynchronous suspend code that
    > a device driver suspending asynchronously may not notice that it
    > should back off. There are two failing scenarions, (1) when the
    > driver is waiting for a driver suspending synchronously to complete
    > and that second driver returns error code, in which case async_error
    > won't be set and the waiting driver will continue suspending and (2)
    > after the driver has called device_pm_wait_for_dev() and the waited
    > for driver returns error code, in which case the caller of
    > device_pm_wait_for_dev() will not know that there was an error and
    > will continue suspending.
    >
    > To fix this issue make __device_suspend() set async_error, so
    > async_suspend() doesn't need to set it any more, and make
    > device_pm_wait_for_dev() return async_error, so that its callers
    > can check whether or not they should continue suspending.
    >
    > No more changes are necessary, since device_pm_wait_for_dev() in
    > not used by any drivers' suspend routines.
    >
    > Reported-by: Colin Cross <ccross@android.com>
    > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>

    Acked-by: Greg Kroah-Hartman <gregkh@suse.de>


    \
     
     \ /
      Last update: 2010-09-20 21:03    [W:0.019 / U:31.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site