Messages in this thread | | | Date | Sun, 19 Sep 2010 23:28:32 -0700 | From | Brian Norris <> | Subject | Re: [PATCH v4] mtd: nand: Expand nand_ecc_layout, deprecate ioctl ECCGETLAYOUT |
| |
Hello,
Now that I've finally gotten around to working on this, I have questions and comments.
On 9/18/2010 10:24 AM, Artem Bityutskiy wrote: > On Mon, 2010-08-30 at 13:20 +0300, Artem Bityutskiy wrote: >> On Tue, 2010-08-24 at 18:12 -0700, Brian Norris wrote: >>> My e-mail address has changed, since I am no longer working at Broadcom. >>> I will still be able to track messages to my old account if the MTD mailing >>> list is CC'd. >> >> Oh, does it mean you will stop loving MTD and we won't see steady flow >> of improvements for you? :-( BTW, I think you have been doing great job >> - MTD subsystem needs love badly!
No, this doesn't mean I will stop loving MTD, although as may be readily apparent by my delay, I may work a bit slower :) In fact, I will probably be picking up some more work shortly.
>>> +/* >>> + * Copies (and truncates, if necessary) data from the larger struct, >>> + * nand_ecclayout, to the smaller, deprecated layout struct, >>> + * nand_ecclayout_user. This is necessary only to suppport the deprecated >>> + * API ioctl ECCGETLAYOUT while allowing all new functionality to use >>> + * nand_ecclayout flexibly (i.e. the struct may change size in new >>> + * releases without requiring major rewrites). >>> + */ >> >> I think a similar comment should exist in linux/mtd/mtd.h. Indeed, that >> file is our API with user-space, and our users will probably look at it, >> and it is nice to document the situation with 'struct >> nand_ecclayout_user' there.
From the context, I assume you meant include/mtd/mtd-abi.h, not linux/mtd/mtd.h; am I correct?
I will send the patch out shortly under the assumption that I am correct.
Brian
| |