lkml.org 
[lkml]   [2010]   [Sep]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] PM: Prevent waiting forever on asynchronous resume after abort
On Thu, 2 Sep 2010, Colin Cross wrote:

> That would work, but I still don't see why it's better. With either
> of your changes, the power.completion variable is storing state, and
> not just used for notification. However, the exact meaning of that
> state is unclear, especially during the transition from an aborted
> suspend to resume, and the state is duplicating power.status. Setting
> it to complete in dpm_prepare is especially confusing, because at that
> point nothing is completed, it hasn't even been started.

The state being waited for varies from time to time and is only
partially related to power.status. Instead of using a completion I
suppose we could have used a new "transition_complete" variable
together with a waitqueue. Would you prefer that? It's effectively
the same thing as a completion, but without the nice packaging already
provided by the kernel.

Alan Stern



\
 
 \ /
  Last update: 2010-09-02 23:37    [W:0.065 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site