Messages in this thread | | | Date | Thu, 2 Sep 2010 15:20:52 -0400 (EDT) | From | Alan Stern <> | Subject | Re: [PATCH] USB: output an error message when the pipe type doesn't match the endpoint type |
| |
On Thu, 2 Sep 2010, Simon Arlott wrote:
> On 02/09/10 15:22, Alan Stern wrote: > > On Thu, 2 Sep 2010, Simon Arlott wrote: > > > >> On Wed, September 1, 2010 18:49, Alan Stern wrote: > >> > On Wed, 1 Sep 2010, Simon Arlott wrote: > >> >> > This is okay with me. If you're serious about not changing the > >> >> > behavior merely because debugging is enabled, you could move this test > >> >> > out of the debug-only region and possibly change the dev_err to > >> >> > dev_dbg. However doing so might break some devices that are currently > >> >> > working. > > > > Which suggests that the best approach is to print the error message > > always, but allow the submission unless CONFIG_USB_DEBUG is set. > > That could result in a lot of error messages, and it doesn't give any > information on which driver caused it,
It would if you added the endpoint number and direction to the error message.
> but a single WARN_ON() would > only be triggered once globally. Each USB device (or endpoint) could > have a "warned" flag.
That seems ridiculous, especially for such a rare bug.
Alan Stern
| |