Messages in this thread | | | Date | Thu, 2 Sep 2010 21:47:36 +0400 | From | Anton Vorontsov <> | Subject | Re: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC |
| |
On Thu, Sep 02, 2010 at 10:29:46AM -0700, rklein@nvidia.com wrote: > From: Rhyland Klein <rklein@nvidia.com> > > this driver depends on I2C and uses SMBUS for communication with the host. > > Addressed comments from reviews by Mark Brown and Jean Delvare. > * Cleaned up whitespace and alignment issues > * changed return codes to more appropriate values > * change Kconfig option name to be consistent with existing devices > * removed global struct and moved to device specific data > * changed printk to dev_dbg
The driver looks good to me. But I'll wait a day or two for Jean's and Mark's Acked-by or Reviewed-by tags before applying, just to give them some credit for reviwing this driver.
Thanks!
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2
| |