lkml.org 
[lkml]   [2010]   [Sep]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/7] w35und: Kill dead HAL macros in wbhal_f.h
Hi!

> Fixes an uninitialized variable access in _rx_iq_calibration_loop_winbond():
>
> CC [M] drivers/staging/winbond/phy_calibration.o
> drivers/staging/winbond/phy_calibration.c: In function ???_rx_iq_calibration_loop_winbond???:
> drivers/staging/winbond/phy_calibration.c:1138: warning: ???val??? is used uninitialized in this function
>

Are you sure this is correct?

> @@ -1132,18 +1132,6 @@ u8 _rx_iq_calibration_loop_winbond(struct hw_data *phw_data, u16 factor, u32 fre
> PHY_DEBUG(("[CAL] -> [5]_rx_iq_calibration_loop()\n"));
> PHY_DEBUG(("[CAL] ** factor = %d\n", factor));
>
> -
> -/* RF Control Override */
> - hw_get_cxx_reg(phw_data, 0x80, &val);
> - val |= BIT(19);
> - hw_set_cxx_reg(phw_data, 0x80, val);
> -

We pass pointer to val somewhere, set a bit, write it back. Seems ok
to me...?

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


\
 
 \ /
  Last update: 2010-09-19 23:45    [W:0.066 / U:0.916 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site