lkml.org 
[lkml]   [2010]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[04/11] irda: off by one
    2.6.27-stable review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Dan Carpenter <error27@gmail.com>

    commit cf9b94f88bdbe8a02015fc30d7c232b2d262d4ad upstream.

    This is an off by one. We would go past the end when we NUL terminate
    the "value" string at end of the function. The "value" buffer is
    allocated in irlan_client_parse_response() or
    irlan_provider_parse_command().

    CC: stable@kernel.org
    Signed-off-by: Dan Carpenter <error27@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>

    ---
    net/irda/irlan/irlan_common.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/irda/irlan/irlan_common.c
    +++ b/net/irda/irlan/irlan_common.c
    @@ -1100,7 +1100,7 @@ int irlan_extract_param(__u8 *buf, char
    memcpy(&val_len, buf+n, 2); /* To avoid alignment problems */
    le16_to_cpus(&val_len); n+=2;

    - if (val_len > 1016) {
    + if (val_len >= 1016) {
    IRDA_DEBUG(2, "%s(), parameter length to long\n", __func__ );
    return -RSP_INVALID_COMMAND_FORMAT;
    }



    \
     
     \ /
      Last update: 2010-09-18 20:51    [W:0.020 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site