Messages in this thread Patch in this message | | | From | Namhyung Kim <> | Subject | [PATCH 4/4] printk: Declare printk_ratelimit_state in ratelimit.h | Date | Sun, 19 Sep 2010 00:53:02 +0900 |
| |
Adding declaration of printk_ratelimit_state in ratelimit.h removes potential build breakage and following sparse warning:
kernel/printk.c:1426:1: warning: symbol 'printk_ratelimit_state' was not declared. Should it be static?
Signed-off-by: Namhyung Kim <namhyung@gmail.com> --- include/linux/ratelimit.h | 4 ++++ kernel/sysctl.c | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/include/linux/ratelimit.h b/include/linux/ratelimit.h index 8f69d09..55e1bbc 100644 --- a/include/linux/ratelimit.h +++ b/include/linux/ratelimit.h @@ -36,6 +36,10 @@ static inline void ratelimit_state_init(struct ratelimit_state *rs, rs->begin = 0; } +#ifdef CONFIG_PRINTK +extern struct ratelimit_state printk_ratelimit_state; +#endif + extern int ___ratelimit(struct ratelimit_state *rs, const char *func); #define __ratelimit(state) ___ratelimit(state, __func__) diff --git a/kernel/sysctl.c b/kernel/sysctl.c index f88552c..720ab2b 100644 --- a/kernel/sysctl.c +++ b/kernel/sysctl.c @@ -161,8 +161,6 @@ extern int no_unaligned_warning; extern int unaligned_dump_stack; #endif -extern struct ratelimit_state printk_ratelimit_state; - #ifdef CONFIG_PROC_SYSCTL static int proc_do_cad_pid(struct ctl_table *table, int write, void __user *buffer, size_t *lenp, loff_t *ppos); -- 1.7.0.4
| |