[lkml]   [2010]   [Sep]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[091/123] sched: Queue a deboosted task to the head of the RT prio queue
From: Thomas Gleixner <>

commit 60db48cacb9b253d5607a5ff206112a59cd09e34 upstream

rtmutex_set_prio() is used to implement priority inheritance for
futexes. When a task is deboosted it gets enqueued at the tail of its
RT priority list. This is violating the POSIX scheduling semantics:

rt priority list X contains two runnable tasks A and B

task A runs with priority X and holds mutex M
task C preempts A and is blocked on mutex M
-> task A is boosted to priority of task C (Y)
task A unlocks the mutex M and deboosts itself
-> A is dequeued from rt priority list Y
-> A is enqueued to the tail of rt priority list X
task C schedules away
task B runs

This is wrong as task A did not schedule away and therefor violates
the POSIX scheduling semantics.

Enqueue the task to the head of the priority list instead.

Reported-by: Mathias Weber <>
Reported-by: Carsten Emde <>
Signed-off-by: Thomas Gleixner <>
Acked-by: Peter Zijlstra <>
Tested-by: Carsten Emde <>
Tested-by: Mathias Weber <>
LKML-Reference: <>
Signed-off-by: Mike Galbraith <>
Signed-off-by: Greg Kroah-Hartman <>
kernel/sched.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -6184,7 +6184,7 @@ void rt_mutex_setprio(struct task_struct
if (running)
if (on_rq) {
- enqueue_task(rq, p, 0, false);
+ enqueue_task(rq, p, 0, oldprio < prio);

check_class_changed(rq, p, prev_class, oldprio, running);

 \ /
  Last update: 2010-09-18 21:17    [W:0.017 / U:1.912 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site