Messages in this thread | | | Date | Fri, 17 Sep 2010 20:17:04 -0700 (PDT) | Subject | Re: [PATCH] fbmem: Fix fb_read, fb_write unaligned accesses. | From | David Miller <> |
| |
From: James Hogan <james@albanarts.com> Date: Sat, 18 Sep 2010 01:23:47 +0100
> Apologies for corrupted patch. I'll try again. > Comments? I'd also appreciate if somebody familiar with sbus on sparc > could check this patch is sane since I know virtually nothing about sbus > and am not in a position to compile for sparc, let alone test on it: > > fb_{read,write} access the framebuffer using lots of fb_{read,write}l's > but don't check that the file position is aligned which can cause > problems on some architectures which do not support unaligned accesses. > > Since the operations are essentially memcpy_{from,to}io, new > fb_memcpy_{from,to}fb macros have been defined and these are used > instead. > > For Sparc, fb_{read,write} macros use sbus_{read,write}, so this defines > new sbus_memcpy_{from,to}io functions the same as memcpy_{from,to}io but > using sbus_{read,write}b instead of {read,write}b. > > Signed-off-by: James Hogan <james@albanarts.com>
Compiles cleanly on sparc and looks correct to me:
Acked-by: David S. Miller <davem@davemloft.net>
| |