Messages in this thread | | | Date | Fri, 17 Sep 2010 18:47:41 +0300 | From | Dzianis Kahanovich <> | Subject | Re: i2c: Re: #2 (Re: More modaliases + patchtool)) |
| |
Mark Brown пишет:
>> + 1 attach for "next" branch. > > Again, please try to follow the process in SubmittingPatches for sending > patches.
One thing (patch) per message?
Yes, I just speculate in this point on fact there are same patch for "next" branch and may be intrpreted as one ;). Sorry.
>> --- linux-2.6.36-rc4-git3/sound/soc/codecs/tlv320dac33.c 2010-09-17 12:30:31.000000000 +0300 >> +++ b/sound/soc/codecs/tlv320dac33.c 2010-09-17 12:39:07.801200070 +0300 >> @@ -1712,6 +1712,9 @@ static int __init dac33_module_init(void >> } >> return 0; >> } >> + >> +MODULE_DEVICE_TABLE(i2c, tlv320dac33_i2c_id); >> + > > This change is OK but should be moved next to the actual table.
This means - after: static const struct i2c_device_id tlv320dac33_i2c_id[] = { ... }
?
IMHO I just copyed style of some of (now not remember) module example in script. OK.
Thanks, next time I will carry out your recomendations. But may be not in script (2) - current way most simple and safe.
-- WBR, Dzianis Kahanovich AKA Denis Kaganovich, http://mahatma.bspu.unibel.by/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |