Messages in this thread | | | Date | Fri, 17 Sep 2010 14:54:15 +0100 | From | Mark Brown <> | Subject | Re: platform: Re: #2 (Re: More modaliases + patchtool)) |
| |
On Fri, Sep 17, 2010 at 04:42:05PM +0300, Dzianis Kahanovich wrote: > ... > Last (14 buses)
Please do try to follow the recommendations in SubmittingPatches, including those regarding the formatting of your mails and CCing relevant maintainers and lists.
> Fix lost PLATFORM modalias > > Signed-off-by: Dzianis Kahanovich <mahatma@eu.by> > > --- linux-2.6.36-rc4-git3/sound/soc/sh/fsi.c 2010-09-17 12:30:32.000000000 +0300 > +++ b/sound/soc/sh/fsi.c 2010-09-17 12:39:08.026437283 +0300 > @@ -1250,6 +1250,9 @@ static void __exit fsi_mobile_exit(void) > { > platform_driver_unregister(&fsi_driver); > } > + > +MODULE_DEVICE_TABLE(platform, fsi_id_table); > +
The normal style for this stuff would be to put the MODULE_DEVICE_TABLE() next to the actual table. I will apply a version of your patch with the addition moved.
| |