lkml.org 
[lkml]   [2010]   [Sep]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update_interval
On Thu, 16 Sep 2010 08:37:15 -0700, Guenter Roeck wrote:
> On Thu, Sep 16, 2010 at 11:14:43AM -0400, Jean Delvare wrote:
> > On Wed, 15 Sep 2010 19:07:14 -0700, Guenter Roeck wrote:
> > > The attribute reflects an interval, not a rate.
> > >
> > > Signed-off-by: Guenter Roeck <guenter.roeck@ericsson.com>
> > > ---
> > > Documentation/hwmon/sysfs-interface | 12 +++++-----
> > > drivers/hwmon/adm1031.c | 43 +++++++++++++++++++---------------
> > > 2 files changed, 30 insertions(+), 25 deletions(-)
> > >
> > > diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> > > index ff45d1f..df0cdd2 100644
> > > --- a/Documentation/hwmon/sysfs-interface
> > > +++ b/Documentation/hwmon/sysfs-interface
> > > @@ -91,13 +91,13 @@ name The chip name.
> > > I2C devices get this attribute created automatically.
> > > RO
> > >
> > > -update_rate The rate at which the chip will update readings.
> > > - Unit: millisecond
> > > +update_interval The interval at which the chip or driver will update readings.
> >
> > I think I prefer the original wording. The attribute is really about
> > setting the register refresh rate at the hardware level. The fact that
> > register cache lifetime in the driver can be adjusted accordingly is an
> > optional implementation detail IMHO.
> >
> Ok, no problem.
>
> > > + Unit: milliseconds
> >
> > Why change? All other units are singular in the file.
> >
> Correct for anything but "milliseconds".
>
> I changed it to milliseconds because all other attributes specify
> "milliseconds". No other reason. Am I missing something ?

I'd rather change all these to "millisecond", so that the document
consistently uses singular for all units.

I also see that the indentation isn't consistent, with power and energy
having 4 tabs where the rest has only 2. Bah.

--
Jean Delvare


\
 
 \ /
  Last update: 2010-09-16 18:45    [W:0.064 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site