Messages in this thread | | | Date | Thu, 16 Sep 2010 15:48:53 +0200 | From | Maurus Cuelenaere <> | Subject | Re: [PATCH v3] USB device driver of Topcliff PCH |
| |
Op 16-09-10 15:39, Masayuki Ohtake schreef: > This patch was modified according to the comments of Maurus and Michal.
This isn't a commit description, if you want to put information about what changed compared to the previous patch, do it ...
> > Signed-off-by: Masayuki Ohtake <masa-korg@dsn.okisemi.com> > ---
... here
(and add a "---\n")
> drivers/usb/gadget/Kconfig | 24 + > drivers/usb/gadget/Makefile | 2 +- > drivers/usb/gadget/gadget_chips.h | 7 + > drivers/usb/gadget/pch_udc.c | 3343 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 3375 insertions(+), 1 deletions(-) > create mode 100644 drivers/usb/gadget/pch_udc.c > [snip] > +static int speed_fs; > +module_param_named(speed_fs, speed_fs, bool, S_IRUGO); > +MODULE_PARM_DESC(speed_fs, "true for Full speed operation"); > +MODULE_DESCRIPTION("OKISEMI PCH USB Device Controller"); > +MODULE_LICENSE("GPL");
MODULE_{DESCRIPTION,LICENSE} is normally put at the end of the file; I don't know if there's a written rule for that? (if not, you can ignore this)
Also, there's no MODULE_AUTHOR?
[snip] > +static inline void pch_udc_bit_set(struct pch_udc_dev *dev, > + unsigned long reg, > + unsigned long bitmask) > +{ > + pch_udc_writel((dev), ((pch_udc_readl((dev), (reg)) | (bitmask))), > + (reg));
nitpick: remove the unneeded parentheses
> +} > +static inline void pch_udc_bit_clr(struct pch_udc_dev *dev, > + unsigned long reg, > + unsigned long bitmask) > +{ > + pch_udc_writel((dev), (pch_udc_readl((dev), (reg)) & (~(bitmask))), > + (reg));
and here
> +} > + [snip] > +static inline void pch_udc_ep_bit_set(struct pch_udc_ep *ep, > + unsigned long reg, > + unsigned long bitmask) > +{ > + pch_udc_ep_writel((ep), ((pch_udc_ep_readl((ep), (reg)) | (bitmask))), > + (reg));
and here
> +} > +static inline void pch_udc_ep_bit_clr(struct pch_udc_ep *ep, > + unsigned long reg, > + unsigned long bitmask) > +{ > + pch_udc_ep_writel((ep), (pch_udc_ep_readl((ep), (reg)) & (~(bitmask))), > + (reg));
here too
> +} > +
-- Maurus Cuelenaere
| |