Messages in this thread | | | Date | Wed, 15 Sep 2010 12:08:33 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH V3] [X86] Fix potential issue on memmove |
| |
On 09/14/2010 06:50 PM, ling.ma@intel.com wrote: > From: Ma Ling <ling.ma@intel.com> > > memmove allow source and destination address to be overlap, > but no limitation for memcpy. So memmove use forward or > backward copy mode to handle src > dest and dest > src cases respectively. > However memcpy has not address overlap, it may use any copy mode > theoretically. Our original memmove will call memcpy and assume > it must use forward copy mode, otherwise the system will crash, > it is potential issue. The patch based on tip/x86/mem avoids > this assumption. > > Signed-off-by: Ma Ling <ling.ma@intel.com>
This patch is certainly not based on the current tip:x86/mem. Could you check out the current tip:x86/mem (which has a previous patch of yours in it) and submit an incremental patch with a description about what updates the previous patch and why?
-hpa
| |