Messages in this thread | | | Date | Wed, 15 Sep 2010 14:48:24 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] block: add assert_spin_locked() to ensure lock is held |
| |
On 2010-09-15 14:33, Namhyung Kim wrote: > Use assert_spin_locked() macro in order to ensure that queue_lock > must be held prior to calling some EXPORTed functions.
As far as I know, no such bug has ever occurred that I know of. So while I don't mind adding such instrumentation, there's little point to doing it when you are not seeing any usability problems in there. And all these paths (requeue less) are heavily used, so problems would appear quickly.
Locking in the block layer is still fairly trivial, we just have the one lock per queue.
-- Jens Axboe
| |