Messages in this thread Patch in this message | | | From | Mel Gorman <> | Subject | [PATCH 5/8] vmscan: Remove dead code in shrink_inactive_list() | Date | Wed, 15 Sep 2010 13:27:48 +0100 |
| |
From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
After synchrounous lumpy reclaim, the page_list is guaranteed to not have active pages as page activation in shrink_page_list() disables lumpy reclaim. Remove the dead code.
Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> Signed-off-by: Mel Gorman <mel@csn.ul.ie> Reviewed-by: Minchan Kim <minchan.kim@gmail.com> --- mm/vmscan.c | 8 -------- 1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/mm/vmscan.c b/mm/vmscan.c index b352b92..00075f3 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1332,7 +1332,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, unsigned long nr_scanned; unsigned long nr_reclaimed = 0; unsigned long nr_taken; - unsigned long nr_active; unsigned long nr_anon; unsigned long nr_file; @@ -1387,13 +1386,6 @@ shrink_inactive_list(unsigned long nr_to_scan, struct zone *zone, /* Check if we should syncronously wait for writeback */ if (should_reclaim_stall(nr_taken, nr_reclaimed, priority, sc)) { - /* - * The attempt at page out may have made some - * of the pages active, mark them inactive again. - */ - nr_active = clear_active_flags(&page_list, NULL); - count_vm_events(PGDEACTIVATE, nr_active); - set_lumpy_reclaim_mode(priority, sc, true); nr_reclaimed += shrink_page_list(&page_list, sc); } -- 1.7.1
| |