lkml.org 
[lkml]   [2010]   [Sep]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/5] kprobes: make functions static
    Date
    make following (internal) functions static to make sparse happier :-)

    * get_optimized_kprobe: only called from static functions
    * kretprobe_table_unlock: _lock function is static
    * kprobes_optinsn_template_holder: never called but holding asm code

    Signed-off-by: Namhyung Kim <namhyung@gmail.com>
    Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    ---
    arch/x86/kernel/kprobes.c | 2 +-
    kernel/kprobes.c | 5 +++--
    2 files changed, 4 insertions(+), 3 deletions(-)

    diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c
    index 770ebfb..05c20a4 100644
    --- a/arch/x86/kernel/kprobes.c
    +++ b/arch/x86/kernel/kprobes.c
    @@ -1129,7 +1129,7 @@ static void __kprobes synthesize_set_arg1(kprobe_opcode_t *addr,
    *(unsigned long *)addr = val;
    }

    -void __kprobes kprobes_optinsn_template_holder(void)
    +static void __used __kprobes kprobes_optinsn_template_holder(void)
    {
    asm volatile (
    ".global optprobe_template_entry\n"
    diff --git a/kernel/kprobes.c b/kernel/kprobes.c
    index 1b0dbe0..c53aad5 100644
    --- a/kernel/kprobes.c
    +++ b/kernel/kprobes.c
    @@ -399,7 +399,7 @@ static inline int kprobe_optready(struct kprobe *p)
    * Return an optimized kprobe whose optimizing code replaces
    * instructions including addr (exclude breakpoint).
    */
    -struct kprobe *__kprobes get_optimized_kprobe(unsigned long addr)
    +static struct kprobe *__kprobes get_optimized_kprobe(unsigned long addr)
    {
    int i;
    struct kprobe *p = NULL;
    @@ -857,7 +857,8 @@ void __kprobes kretprobe_hash_unlock(struct task_struct *tsk,
    spin_unlock_irqrestore(hlist_lock, *flags);
    }

    -void __kprobes kretprobe_table_unlock(unsigned long hash, unsigned long *flags)
    +static void __kprobes kretprobe_table_unlock(unsigned long hash,
    + unsigned long *flags)
    {
    spinlock_t *hlist_lock = kretprobe_table_lock_ptr(hash);
    spin_unlock_irqrestore(hlist_lock, *flags);
    --
    1.7.2.2


    \
     
     \ /
      Last update: 2010-09-15 03:07    [W:0.023 / U:0.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site