Messages in this thread | | | Date | Tue, 14 Sep 2010 21:47:54 +0300 | Subject | Re: [PATCH 2/2] SLUB: Mark merged slab caches in /proc/slabinfo | From | Pekka Enberg <> |
| |
On Tue, Sep 14, 2010 at 9:05 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote: >> Looking at procps sources, slabtop and other utilities seem to think >> slab cache names are limited to 64 bytes. Linus, are you OK with >> adding a "+" character prefix for merged caches like you suggested in >> private? > > I'd much rather see "x+y+z" and actually see what the slab entries are. > > But we can certainly also say "limit it to 64 bytes" and truncate > things past that.
It's actually 63 bytes due to off-by-one error in procps. There never has been such limit on the kernel side but I worry about breaking other applications that are prepared to read even less characters. Oh well, I'll send the reworked patches and let you decide.
Pekka
| |