[lkml]   [2010]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over

Ming Lei wrote:

>> But why not modify the conditional above all that code, just excluding
>> 'is_dma' from it. This conditional already includes (request->actual ==
>> request->length) check. Please recast this patch.

> The two condition is OR relation, not and, so we can't exclude 'is_dma' simply.

Yes, we can. You're clearly handling only the DMA case with your added
check, the PIO case was already handled.

> Anyway, the change is not wrong, right?

Not wrong, but the check is duplicate.

> thanks,

WBR, Sergei

 \ /
  Last update: 2010-09-13 17:55    [W:0.155 / U:20.568 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site