lkml.org 
[lkml]   [2010]   [Sep]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RESEND/PATCH 5/6] USB: musb-gadget: complete request only if data is transfered over
Hello.

tom.leiming@gmail.com wrote:

> From: Ming Lei <tom.leiming@gmail.com>

> Complete the current request only if the data transfer is over.

> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> Cc: David Brownell <dbrownell@users.sourceforge.net>
> Cc: Felipe Balbi <me@felipebalbi.com>
> Cc: Anand Gadiyar <gadiyar@ti.com>
> Cc: Mike Frysinger <vapier@gentoo.org>
> Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> ---
> drivers/usb/musb/musb_gadget.c | 16 ++++++++--------
> 1 files changed, 8 insertions(+), 8 deletions(-)

> diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
> index f3ee04f..fa826f9 100644
> --- a/drivers/usb/musb/musb_gadget.c
> +++ b/drivers/usb/musb/musb_gadget.c
> @@ -501,14 +501,14 @@ void musb_g_tx(struct musb *musb, u8 epnum)
> request->zero = 0;
> }
>
> - /* ... or if not, then complete it. */
> - musb_g_giveback(musb_ep, request, 0);
> -
> - request = musb_ep->desc ? next_request(musb_ep) : NULL;
> - if (!request) {
> - DBG(4, "%s idle now\n",
> - musb_ep->end_point.name);
> - return;
> + if (request->actual == request->length) {

But why not modify the conditional above all that code, just excluding
'is_dma' from it. This conditional already includes (request->actual ==
request->length) check. Please recast this patch.

> + musb_g_giveback(musb_ep, request, 0);
> + request = musb_ep->desc ? next_request(musb_ep) : NULL;
> + if (!request) {
> + DBG(4, "%s idle now\n",
> + musb_ep->end_point.name);
> + return;
> + }
> }
> }
>

WBR, Sergei


\
 
 \ /
  Last update: 2010-09-13 14:31    [W:0.125 / U:2.096 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site