Messages in this thread |  | | Date | Sat, 11 Sep 2010 11:38:11 +0200 | | From | Florian Mickler <> | | Subject | Re: [PATCH] scripts/get_maintainer.pl: Add --git-blame --rolestats "Authored lines" information |
| |
On Fri, 10 Sep 2010 17:22:21 -0700 Joe Perches <joe@perches.com> wrote:
> > > Something based on percentage of the driver written rather than log > > > entry counts might also be interesting. > > There is a --git-blame option, but it uses a count of file commits > > active in the file rather than % of lines authored. > > When options --git-blame and --rolestats are specified, add > the maintainers with the qualifying --git-min-percent amount > of lines authored of the complete file. Does not add more > authors than specified by --git-max-maintainers. > > For anyone using hg, this option works but is _very_ slow. > It's orders of magnitude slower than git slow. > > The get_maintainer.pl version was incremented to 0.25. > > This can be used with or without --git. > > For instance: > > $ ./scripts/get_maintainer.pl --git-blame --nogit --rolestats -f lib/bitmap.c > Paul Jackson <pj@sgi.com> (authored lines:406/613=66%,commits:7/20=35%) > Akinobu Mita <mita@miraclelinux.com> (authored lines:87/613=14%,commits:3/20=15%) > Reinette Chatre <reinette.chatre@linux.intel.com> (authored lines:42/613=7%) > Andrew Morton <akpm@linux-foundation.org> (commits:16/20=80%) > Paul Mundt <lethal@linux-sh.org> (commits:3/20=15%) > Randy Dunlap <randy.dunlap@oracle.com> (commits:2/20=10%) > > $ ./scripts/get_maintainer.pl --git-blame --git --rolestats -f lib/bitmap.c > Andrew Morton <akpm@linux-foundation.org> (commit_signer:4/5=80%,commits:16/20=80%) > Akinobu Mita <akinobu.mita@gmail.com> (commit_signer:2/5=40%,authored lines:87/613=14%,commits:3/20=15%) > Jack Steiner <steiner@sgi.com> (commit_signer:1/5=20%) > Ben Hutchings <ben@decadent.org.uk> (commit_signer:1/5=20%) > Lee Schermerhorn <lee.schermerhorn@hp.com> (commit_signer:1/5=20%) > Paul Jackson <pj@sgi.com> (authored lines:406/613=66%,commits:7/20=35%) > Reinette Chatre <reinette.chatre@linux.intel.com> (authored lines:42/613=7%) > Paul Mundt <lethal@linux-sh.org> (commits:3/20=15%) > Randy Dunlap <randy.dunlap@oracle.com> (commits:2/20=10%) > linux-kernel@vger.kernel.org (open list) > > Signed-off-by: Joe Perches <joe@perches.com>
I think this is a good change. I also think this should be made default. (linestat is probably more of a hint then nr of commits.
But I don't think it really solves the same problem as the annotations on the name. We really want to show who just used a script to cc people and who made an effort to find the right people to send the patch to.
Cheers, Flo
|  |