Messages in this thread Patch in this message | | | Date | Fri, 10 Sep 2010 23:13:33 -0600 | From | Jean Sacren <> | Subject | [PATCH 1/1] scripts: Enable error messages while hush up unnecessary warnings |
| |
As no error was handled, we wouldn't be able to know when an error does occur. The fix preserves error messages while it doesn't let unnecessary compiling warnings show up.
Signed-off-by: Jean Sacren <sakiwit@gmail.com> --- scripts/kallsyms.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c index e3902fb..60dd3eb 100644 --- a/scripts/kallsyms.c +++ b/scripts/kallsyms.c @@ -107,12 +107,8 @@ static int read_symbol(FILE *in, struct sym_entry *s) rc = fscanf(in, "%llx %c %499s\n", &s->addr, &stype, str); if (rc != 3) { - if (rc != EOF) { - /* skip line. sym is used as dummy to - * shut of "warn_unused_result" warning. - */ - sym = fgets(str, 500, in); - } + if (rc != EOF && fgets(str, 500, in) == NULL) + fprintf(stderr, "Read error or end of file.\n"); return -1; } -- 1.7.1
| |