lkml.org 
[lkml]   [2010]   [Sep]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 1/4] hugetlb, rmap: always use anon_vma root pointer
    On Thu, Sep 9, 2010 at 9:23 PM, Naoya Horiguchi
    <n-horiguchi@ah.jp.nec.com> wrote:
    > This patch applies Andrea's fix given by the following patch into hugepage
    > rmapping code:
    >
    >  commit 288468c334e98aacbb7e2fb8bde6bc1adcd55e05
    >  Author: Andrea Arcangeli <aarcange@redhat.com>
    >  Date:   Mon Aug 9 17:19:09 2010 -0700
    >
    > This patch uses anon_vma->root and avoids unnecessary overwriting when
    > anon_vma is already set up.

    Btw, why isn't the code in __page_set_anon_rmap() also doing this
    cleaner version (ie a single "if (PageAnon(page)) return;" up front)?

    The comments in that function are also some alien language translated
    to english by some broken automatic translation service. Could
    somebody clean up that function and come up with a comment that
    actually parses as English and makes sense?

    Linus
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-09-10 19:23    [W:0.030 / U:150.272 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site