Messages in this thread | | | Date | Fri, 10 Sep 2010 11:56:05 -0400 | From | Don Zickus <> | Subject | Re: [RFC 4/6] x86, NMI, Rewrite NMI handler |
| |
On Fri, Sep 10, 2010 at 10:51:03AM +0800, Huang Ying wrote: > The original NMI handler is quite outdated in many aspects. This patch > try to fix it. > > In original code, NMI reason io port (0x61) is only processed on > BSP. This makes it impossible to hot-remove BSP. To solve the issue, > a raw spinlock is used to make the port can be processed on any CPU.
Do we really want to use a spinlock inside the nmi handler?
I thought the NMIs sent to the io port are only routed to one cpu as determined by the io-apic? Is it spread out to other cpus now?
Cheers, Don
| |