Messages in this thread | | | Date | Wed, 1 Sep 2010 13:16:22 -0400 | From | "John W. Linville" <> | Subject | Re: [PATCH][GIT PULL] ring-buffer: Place duplicate expression into a single function |
| |
On Wed, Sep 01, 2010 at 12:49:52PM -0400, Steven Rostedt wrote: > > Ingo, > > Please pull the latest tip/perf/core tree, which can be found at: > > git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-2.6-trace.git > tip/perf/core > > > Steven Rostedt (1): > ring-buffer: Place duplicate expression into a single function > > ---- > kernel/trace/ring_buffer.c | 21 +++++++++++++++------ > 1 files changed, 15 insertions(+), 6 deletions(-) > --------------------------- > commit f6195aa09e618d712f52bf4fa33b5293820eb93d > Author: Steven Rostedt <srostedt@redhat.com> > Date: Wed Sep 1 12:23:12 2010 -0400 > > ring-buffer: Place duplicate expression into a single function > > While discussing the strictness of the 80 character limit on the > Kernel Summit Discussion mailing list, I showed examples that I > broke that limit slightly with some algorithms. In discussing with > John Linville, what looked better, I realized that two of the > 80 char breaking culprits were an identical expression. > > As a clean up, this patch moves the identical expression into its > own helper function and that is used instead. As a side effect, > the offending code is now under the 80 character limit. :-) > > This clean up code also changes the expression from > > (A - B) - C to A - (B + C) > > This makes the code look a little nicer too. > > Cc: John W. Linville <linville@tuxdriver.com> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
ACK :-)
-- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.
| |