Messages in this thread | | | From | Andi Kleen <> | Subject | Re: [PATCH] x86: remove __phys_reloc_hide | Date | Mon, 09 Aug 2010 08:22:34 +0200 |
| |
Namhyung Kim <namhyung@gmail.com> writes:
> remove unnecessary use of RELOC_HIDE(). It only does simple addition of ptr > and offset, and in this case, offset 0, does nothing. It does NOT do anything > with linker relocation things. I could find no reason to use it.
It's for the benefit of the compiler, we've had miscompilations due to undefined overflow for addresses in the past. The optimizer assumes this won't happen.
Given the x86-64 version normally doesn't overflow, but it's still safer to have it.
-Andi
-- ak@linux.intel.com -- Speaking for myself only.
| |