Messages in this thread | | | Date | Sun, 8 Aug 2010 06:33:23 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader. |
| |
--- On Sat, 7/8/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote: > > > > > > > > > > Btw, I want to add a callback from > driver to card > > > driver to > > > > > be able to > > > > > reset card in case of error (windows > driver does > > > that in > > > > > case of any > > > > > error) > > > > > > > > > > I would use most of the > mspro_block_resume for > > > the > > > > > implementation for > > > > > mspro. > > > > > > > > > > Any objections, suggestions? > > > > > > > > > > > > > Just toggle a power on it. Power off/power > on will do > > > the full reset of > > > > the controller and the media. You don't have > to > > > reinitialize it, as you > > > > are sure that it's the same stick. > > > > > > Yea, but after such reboot, the device will be in > serial > > > mode. So, I > > > will need to send switch TPC to device. My driver > doesn't > > > know how to do > > > that...., so it would be nice to have callback to > the > > > core. > > > > > > > Lets ask a different question: why do you think this > > particular functionality is needed at all? Have you > encountered any > > problems which require it (I haven't, btw)? > > I would image using this to verify that stick is still in > place on I/O > error. > > If I just power down/up it, it will loose state, for > example IO mode, > reg range, etc... > > But anyway, this isn't very important. >
My point was, that problems are better solved as they come. Windows drivers do a lot of things (like SCSI device emulation), but it doesn't mean all of them are necessary. Adding code "just because" often means more work later on.
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |