Messages in this thread | | | Date | Sun, 8 Aug 2010 06:31:10 -0700 (PDT) | From | Alex Dubov <> | Subject | Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader. |
| |
--- On Sat, 7/8/10, Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> From: Maxim Levitsky <maximlevitsky@gmail.com> > Subject: Re: [PATCH 2/2] MEMSTICK: Add driver for Ricoh R5C592 Card reader. > To: "Alex Dubov" <oakad@yahoo.com> > Cc: "LKML" <linux-kernel@vger.kernel.org> > Received: Saturday, 7 August, 2010, 8:58 AM > On Sat, 2010-08-07 at 06:15 -0700, > Alex Dubov wrote: > > > > > > > > > > > > > > > > > > That's how its > called in the > > > spec. > > > > > > > > > Sectors can be > larger than > > > 512b on > > > > > Pro-HG sticks, and > > > > > > > > there's additional > > > > > > > > > > TPC_READ/WRITE_QUAD_DATA > > > which operates > > > > > on larger > > > > > > > > quantities. > > > > > > > > But not on ordinary PRO, > right? > > > > > > > > > > > > > > Pro sectors are normally 512 > bytes. > > > > > > > > > > > > > > > > > > > > > > > Small question, can I > use Pro-HG > > > stick in my > > > > > reader that is > > > > > > > > designed for > > > > > > > > Standard/PRO only? Does > your > > > subsystem > > > > > support it? > > > > > > > > > > > > > > It should work. It works for > me on TI, > > > which has > > > > > no 8b mode either. > > > > > > In that case, is there an upper > limit on > > > sector size? > > > > > Also, you don't use the > MS_TPC_READ_QUAD_DATA at > > > all. > > > > > So mspro_blk.c won't work with >512 > > > bytes/sector disk? > > > > > Or there is some compatibility? > > > > > > > > > > > > > The code can work with arbitrarily sized > pages, 512b > > > > value is not hard coded. All that is needed > is to > > > slightly alter > > > > h_mspro_block_transfer_data function, given, > of > > > course, that adapters > > > > support longer transfer > > > > > > No, I mean if I go and buy memstick PRO HG, that > has > > > > 512 bytes/sector, > > > will it work with current code? > > > > > > Btw, there is currently no way of telling core > about > > > maximum transfer > > > length. > > > Here absolute maximum is 1024 (number of bit that > _might_ > > > hold TPC > > > length), and FIFO size is 512 bytes (maybe its > possible to > > > use fifo > > > twice) > > > > > > > On TI adapters, FIFO can be reused and DMA restarted. > Jmicron adapters are > > funny beasts, but their team is keen to support > MSpro-HG, so at some > > point it will be fully possible, though, probably, not > with every version > > of the chipset. > > > > I still need an answer for whether HG sticks need > MS_TPC_READ_QUAD_DATA > to be used.
No, they work fine with LONG_DATA, at least the ones I tried.
> > But anyway, I buy a HG stick and see how it works.
This is always a right thing to do.
> > Best regards, > Maxim Levitsky > >
| |