lkml.org 
[lkml]   [2010]   [Aug]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/1] integer overflow issue in 'appletouch' driver
From
Date
On Sun, 2010-08-08 at 18:24 -0700, Vadim Zaliva wrote:
> I have tested the patch on device I had
> I will have an access to it to retest later thus week. We can wait for my
> test to try to identify how my PowerBook is different from yours. Or you
> can roll the patch back.

I'd rather roll the patch back for now. I'll send the revert as part of
the next powerpc update. We'll sort things out then.

Cheers,
Ben.

>
> --
> Sent from my iPhone
>
> On Aug 8, 2010, at 17:20, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> >
> >>> My device is 05ac:020e "fountain", actually generates *signed* values,
> >>> thus the patch completely breaks it.
> >>
> >> I think Ben might have the same issue. I guess we need per-touchpad
> >> functions to read the data.
> >
> > Yup, I confirm, same deal. This patch completely breaks it on my
> > powerbook (same USB ID)
> >
> > Should we revert the commit for now ?
> >
> > Cheers,
> > Ben.
> >




\
 
 \ /
  Last update: 2010-08-09 05:45    [W:0.068 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site