lkml.org 
[lkml]   [2010]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/18] staging: crystalhd: call disable_pci_device() if pci_probe() failed
    Date
    Driver should call disable_pci_device() if it returns from pci_probe()
    with error. Also it must not be called if pci_request_region() fails as
    it means that somebody uses device resources and rules the device.

    Signed-off-by: Kulikov Vasiliy <segooon@gmail.com>
    ---
    drivers/staging/crystalhd/crystalhd_lnx.c | 2 ++
    1 files changed, 2 insertions(+), 0 deletions(-)

    diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c b/drivers/staging/crystalhd/crystalhd_lnx.c
    index fbb80f0..0e52075 100644
    --- a/drivers/staging/crystalhd/crystalhd_lnx.c
    +++ b/drivers/staging/crystalhd/crystalhd_lnx.c
    @@ -570,6 +570,8 @@ static int __devinit chd_dec_pci_probe(struct pci_dev *pdev,
    rc = chd_pci_reserve_mem(pinfo);
    if (rc) {
    BCMLOG_ERR("Failed to setup memory regions.\n");
    + if (rc != -EBUSY)
    + pci_disable_device(pdev);
    return -ENOMEM;
    }

    --
    1.7.0.4


    \
     
     \ /
      Last update: 2010-08-06 21:55    [W:0.021 / U:31.920 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site