Messages in this thread | | | Date | Fri, 6 Aug 2010 09:57:58 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/2] serport: place serport serio device correctly in the device tree |
| |
On Fri, Aug 06, 2010 at 08:29:29PM +0400, Dmitry Eremin-Solenikov wrote: > Make serport serio device to be a child of corresponding tty device > instead of just hanging at /sys/devices/serioX. > > Signed-off-by: Dmitry Eremin-Solenikov <dbaryshkov@gmail.com> > --- > drivers/input/serio/serport.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/drivers/input/serio/serport.c b/drivers/input/serio/serport.c > index 6d34511..ee0ff0c 100644 > --- a/drivers/input/serio/serport.c > +++ b/drivers/input/serio/serport.c > @@ -165,6 +165,7 @@ static ssize_t serport_ldisc_read(struct tty_struct * tty, struct file * file, u > serio->open = serport_serio_open; > serio->close = serport_serio_close; > serio->port_data = serport; > + serio->dev.parent = tty_get_device(tty);
You just grabbed a reference to this device, do you ever need to free it up?
thanks,
greg k-h
| |