lkml.org 
[lkml]   [2010]   [Aug]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 3/3] lib: vsprintf: added a put_dec() test and benchmark tool
    Date
    Hi,

    Michał Nazarewicz <m.nazarewicz@samsung.com> writes:

    > On Fri, 06 Aug 2010 07:10:06 +0200, Denys Vlasenko <vda.linux@googlemail.com> wrote:
    >
    >> On Friday 06 August 2010 00:38, Michal Nazarewicz wrote:
    >>> This commit adds a test application for the put_dec() and
    >>> family of functions that are used by the previous two commits.
    >>>
    >>> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
    >>
    >>> +put-dec-test: put-dec-test.c
    >>> + exec $(CC) $(CFLAGS) -o $@ $<
    >>
    >> (1) Why exec?
    >
    > Micro Makefile optimisation -- saves us a fork().

    I don't think it's worth it. The use of 'exec' will force make to
    invoke the shell, while without the exec, make has an opportunity to
    optimize out the shell invocation completely [1]. Forcing the use of a
    shell to avoid a fork() sounds like a terrible trade-off.

    - Hari

    [1] See, for instance, construct_command_argv_internal() in

    http://cvs.savannah.gnu.org/viewvc/make/job.c?root=make&view=markup

    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2010-08-06 18:01    [W:0.065 / U:29.236 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site