Messages in this thread | | | Date | Fri, 6 Aug 2010 10:45:47 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH] regulator: max1586 - fix a memory leak in max1586_pmic_remove() |
| |
On Fri, Aug 06, 2010 at 01:33:15PM +0800, Axel Lin wrote: > In max1586_pmic_probe(), we allocate memory for max1586. > In max1586_pmic_remove(), current implementation only free rdev > which is a member of struct max1586_data. > Thus, there is a small memory leak when we unload the module. > > This patch fixes the memory leak by passing max1586 to i2c clientdata, > and properly kfree(max1586) in max1586_pmic_remove(). > > Signed-off-by: Axel Lin <axel.lin@gmail.com>
Like with the max8660-patch:
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |