Messages in this thread Patch in this message | | | Subject | [PATCH 2/2 RESEND] regulator: lp3971 - remove redundant checking for count in lp3971_i2c_read() | From | Axel Lin <> | Date | Fri, 06 Aug 2010 08:11:45 +0800 |
| |
We already check count value before calling i2c_smbus_read_byte_data(), no need to check it again.
Signed-off-by: Axel Lin <axel.lin@gmail.com> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com> --- This resend adds regulator: prefix in the subject line. drivers/regulator/lp3971.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/regulator/lp3971.c b/drivers/regulator/lp3971.c index d4d9822..3bb82b6 100644 --- a/drivers/regulator/lp3971.c +++ b/drivers/regulator/lp3971.c @@ -377,7 +377,7 @@ static int lp3971_i2c_read(struct i2c_client *i2c, char reg, int count, if (count != 1) return -EIO; ret = i2c_smbus_read_byte_data(i2c, reg); - if (ret < 0 || count != 1) + if (ret < 0) return -EIO; *dest = ret; -- 1.5.4.3
| |