Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: [PATCH] RFC: AMBA bus discardable probe() function | Date | Wed, 4 Aug 2010 23:43:26 -0700 |
| |
On Wednesday, August 04, 2010 11:26:00 pm Linus WALLEIJ wrote: > [Greg] > > > [Me] > > > > > + spin_lock(&amba_bustype.p->klist_drivers.k_lock); > > > > Ick, nope, you can't do this, sorry. That's a "private" structure for > > a reason. > > Yeah I get it, but in the platform bus case what's that traversal of > the klists actually for? I didn't get it, and was guessing that it > was considering the case where devices spawn new devices.
It is to check if the driver actually bound to any devices and fail driver registration if it did not - then, in case of modular build, entire driver module might get unloaded from memory as well.
-- Dmitry
| |