Messages in this thread Patch in this message | | | From | Jason Wessel <> | Subject | [PATCH 17/17] debug_core,kdb: fix crash when arch does not have single step | Date | Thu, 5 Aug 2010 09:37:58 -0500 |
| |
When an arch such as mips and microblaze does not implement either HW or software single stepping the debug core should re-enter kdb. The kdb code will properly ignore the single step operation. Attempting to single step the kernel without software or hardware support causes unpredictable kernel crashes.
Signed-off-by: Jason Wessel <jason.wessel@windriver.com> --- kernel/debug/debug_core.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c index 8bc5eef..9ed9307 100644 --- a/kernel/debug/debug_core.c +++ b/kernel/debug/debug_core.c @@ -605,6 +605,8 @@ cpu_master_loop: if (dbg_kdb_mode) { kgdb_connected = 1; error = kdb_stub(ks); + if (error == -1) + continue; kgdb_connected = 0; } else { error = gdb_serial_stub(ks); -- 1.6.3.3
| |