lkml.org 
[lkml]   [2010]   [Aug]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] stop_machine: struct cpu_stopper, remove alignment padding on 64 bits
From
Date
On Thu, 2010-08-05 at 12:11 +0100, Richard Kennedy wrote:
> Reorder elements in structure cpu_stopper to remove alignment padding on
> 64 bit builds, this shrinks its size from 40 to 32 bytes saving 8 bytes
> per cpu.
>
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>

Looks good to me. Tejun will you take it or should I send it Ingo wards?

> ---
> diff --git a/kernel/stop_machine.c b/kernel/stop_machine.c
> index 70f8d90..4372ccb 100644
> --- a/kernel/stop_machine.c
> +++ b/kernel/stop_machine.c
> @@ -35,9 +35,9 @@ struct cpu_stop_done {
> /* the actual stopper, one per every possible cpu, enabled on online cpus */
> struct cpu_stopper {
> spinlock_t lock;
> + bool enabled; /* is this stopper enabled? */
> struct list_head works; /* list of pending works */
> struct task_struct *thread; /* stopper thread */
> - bool enabled; /* is this stopper enabled? */
> };
>
> static DEFINE_PER_CPU(struct cpu_stopper, cpu_stopper);
>
>




\
 
 \ /
  Last update: 2010-08-05 13:43    [W:0.049 / U:0.224 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site