| Date | Wed, 4 Aug 2010 16:38:04 -0700 | From | Andrew Morton <> | Subject | Re: [PATCHv3 16/16] pps: add parallel port PPS signal generator |
| |
On Thu, 5 Aug 2010 01:06:53 +0400 Alexander Gordeev <lasaine@lvk.cs.msu.su> wrote:
> Add PPS signal generator which utilizes STROBE pin of a parallel port to > send PPS signals. It uses parport abstraction layer and hrtimers to > precisely control the signal. > > .. > > +static unsigned int send_delay = 30000; > +MODULE_PARM_DESC(delay, > + "Delay between setting and dropping the signal (ns)"); > +module_param_named(delay, send_delay, uint, 0);
This code doesn't look easy to configure and use. For example, if some random person tries to get it going, how does he even know that this module parameter exists, let alone how to use it?
Please review Documentation/pps/pps.txt and check that it accurately and completely describes how to use the pps code after your changes, thanks.
|