lkml.org 
[lkml]   [2010]   [Aug]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] powerpc: Add vmcoreinfo symbols to allow makdumpfile to filter core files properly
    On Tue, Jul 13, 2010 at 09:46:09AM -0400, Neil Horman wrote:
    > Hey all-
    > About 2 years ago now, I sent this patch upstream to allow makedumpfile
    > to properly filter cores on ppc64:
    > http://www.mail-archive.com/kexec@lists.infradead.org/msg02426.html
    > It got acks from the kexec folks so I pulled it into RHEL, but I never checked
    > back here to make sure it ever made it in, which apparently it didn't. It still
    > needs to be included, so I'm reposting it here, making sure to copy all the ppc
    > folks this time. I've retested it on the latest linus kernel and it works fine,
    > allowing makedumpfile to find all the symbols it needs to properly strip a
    > vmcore on ppc64.
    >
    > Neil
    >
    > Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
    >
    >
    > machine_kexec.c | 12 ++++++++++++
    > 1 file changed, 12 insertions(+)
    >
    >
    > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
    > index bb3d893..0df7031 100644
    > --- a/arch/powerpc/kernel/machine_kexec.c
    > +++ b/arch/powerpc/kernel/machine_kexec.c
    > @@ -45,6 +45,18 @@ void machine_kexec_cleanup(struct kimage *image)
    > ppc_md.machine_kexec_cleanup(image);
    > }
    >
    > +void arch_crash_save_vmcoreinfo(void)
    > +{
    > +
    > +#ifdef CONFIG_NEED_MULTIPLE_NODES
    > + VMCOREINFO_SYMBOL(node_data);
    > + VMCOREINFO_LENGTH(node_data, MAX_NUMNODES);
    > +#endif
    > +#ifndef CONFIG_NEED_MULTIPLE_NODES
    > + VMCOREINFO_SYMBOL(contig_page_data);
    > +#endif
    > +}
    > +
    > /*
    > * Do not allocate memory (or fail in any way) in machine_kexec().
    > * We are past the point of no return, committed to rebooting now.
    >
    > _______________________________________________
    > kexec mailing list
    > kexec@lists.infradead.org
    > http://lists.infradead.org/mailman/listinfo/kexec
    >

    Ping yet again. Ben, This needs review/acceptance from you or Paul
    Neil


    \
     
     \ /
      Last update: 2010-08-04 16:55    [W:0.022 / U:1.176 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site