lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH v2] GPIO: add support for 74HC164 serial-in/parallel-out 8-bit shift register
Date
Hi David,

On Tuesday 31 August 2010 01:43:04 David Brownell wrote:
> generic to all
>
> > 74HC164 chips
>
> Not just HC-series logic, also HCT, AC, etc (as
> I noted previously).
>
> I'm glad you took NXP (one of the N vendors)
> out of the name, but I think you should also
> take the logic series out; "74x164 might be sufficiently generic.

Allright, I will respin with those changes. Note that I chose to prefix the
data structures with gen_ (for obvious C language reasons), I hope this is
fine.

>
>
> > pdata->gpio_pin_clk, err);
>
> I'm a bit puzzled why you don't just hook the
> chip up using standard SPI signals... ISTR they
> matched up directly to what the chip needs, so
> no GPIOs were needed for interface glue.

The board this driver is being used on had no SPI signals left I think, so it
was hooked up on separate GPIO lines (which cannot be muxed to the GPIO pad).
--
Florian



\
 
 \ /
  Last update: 2010-08-31 10:23    [W:0.420 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site