Messages in this thread | | | Date | Tue, 31 Aug 2010 12:43:16 +0530 | Subject | Re: [PATCH 1/3] drivers: misc: ak8974 / ami305 magnetometer driver | From | Sundar <> |
| |
Hi again,
On Mon, Aug 30, 2010 at 12:42 PM, Onkalo Samu <samu.p.onkalo@nokia.com> wrote: > > It would require some more operations since the chip would loose its > state totally. But yes, it could be done. > Yes. Something like re-programming the context. but it would make sure that the module draws no power at all.
Also, would it not be correct to include a cancel_work_sync in case of return here?
+fail4: + misc_deregister(&chip->miscdev); +fail3: + ak8974_regulators_off(chip); +fail2: + regulator_bulk_free(ARRAY_SIZE(chip->regs), chip->regs); +fail1: + kfree(chip); + return err; +}
Cheers!
| |