lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 5/7] arch/powerpc/sysdev/qe_lib/qe.c: Add of_node_put to avoid memory leak
    From
    Date

    On Aug 29, 2010, at 4:52 AM, Julia Lawall wrote:

    > Add a call to of_node_put in the error handling code following a call to
    > of_find_compatible_node.
    >
    > The semantic match that finds this problem is as follows:
    > (http://coccinelle.lip6.fr/)
    >
    > // <smpl>
    > @r exists@
    > local idexpression x;
    > expression E,E1;
    > statement S;
    > @@
    >
    > *x =
    > (of_find_node_by_path
    > |of_find_node_by_name
    > |of_find_node_by_phandle
    > |of_get_parent
    > |of_get_next_parent
    > |of_get_next_child
    > |of_find_compatible_node
    > |of_match_node
    > )(...);
    > ...
    > if (x == NULL) S
    > <... when != x = E
    > *if (...) {
    > ... when != of_node_put(x)
    > when != if (...) { ... of_node_put(x); ... }
    > (
    > return <+...x...+>;
    > |
    > * return ...;
    > )
    > }
    > ...>
    > of_node_put(x);
    > // </smpl>
    >
    > Signed-off-by: Julia Lawall <julia@diku.dk>
    >
    > ---
    > arch/powerpc/sysdev/qe_lib/qe.c | 1 +
    > 1 file changed, 1 insertion(+)

    applied to merge

    - k


    \
     
     \ /
      Last update: 2010-08-31 23:45    [W:0.021 / U:91.004 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site