lkml.org 
[lkml]   [2010]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFC] pid: make setpgid() system call use RCU read-side critical section
Date
Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:

> write_lock_irq(&tasklist_lock);
>
> err = -ESRCH;
> + rcu_read_lock();
> ...
> + rcu_read_unlock();
> write_unlock_irq(&tasklist_lock);

I would generally put the rcu lock outside the IRQ disabled section on the
basis that it's better to keep the amount of time we have interrupts disabled
shortest.

> Located-by: Andrew Morton <akpm@linux-foundation.org>

'Reported-by' might be more consistent with what others use.

David


\
 
 \ /
  Last update: 2010-08-31 15:07    [W:0.093 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site