Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH RFC] pid: make setpgid() system call use RCU read-side critical section | Date | Tue, 31 Aug 2010 14:02:31 +0100 |
| |
Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> write_lock_irq(&tasklist_lock); > > err = -ESRCH; > + rcu_read_lock(); > ... > + rcu_read_unlock(); > write_unlock_irq(&tasklist_lock);
I would generally put the rcu lock outside the IRQ disabled section on the basis that it's better to keep the amount of time we have interrupts disabled shortest.
> Located-by: Andrew Morton <akpm@linux-foundation.org>
'Reported-by' might be more consistent with what others use.
David
| |