Messages in this thread Patch in this message | | | Date | Tue, 31 Aug 2010 15:36:13 +1000 | From | Anton Blanchard <> | Subject | Re: [PATCH 03/10] Use percpu stats |
| |
Hi,
> + zram->stats = alloc_percpu(struct zram_stats_cpu); > + if (!zram->stats) { > + pr_err("Error allocating percpu stats\n"); > + ret = -ENOMEM; > + goto fail; > + }
There doesn't seem to be a free_percpu() in the module exit path. Something like this perhaps?
Anton --
zram: Free percpu data on module exit.
Signed-off-by: Anton Blanchard <anton@samba.org> ---
Index: powerpc.git/drivers/staging/zram/zram_drv.c =================================================================== --- powerpc.git.orig/drivers/staging/zram/zram_drv.c 2010-08-31 15:15:59.344290847 +1000 +++ powerpc.git/drivers/staging/zram/zram_drv.c 2010-08-31 15:17:00.383045836 +1000 @@ -483,8 +483,7 @@ void zram_reset_device(struct zram *zram xv_destroy_pool(zram->mem_pool); zram->mem_pool = NULL; - /* Reset stats */ - memset(&zram->stats, 0, sizeof(zram->stats)); + free_percpu(&zram->stats); zram->disksize = zram_default_disksize(); mutex_unlock(&zram->init_lock);
| |