Messages in this thread | | | Date | Mon, 30 Aug 2010 17:57:04 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache |
| |
> > @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super > > } else { > > ext3_msg(sb, KERN_INFO, "using internal journal"); > > } > > + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE); > > Do you really need to pass in the page size? What about just > "cleancache_init_fs(sb)" rather than exposing the > "sb->cleancache_poolid"? In other words, what if you want to do > more/other per-filesystem init at some point?
IIRC, I think I was trying to stay away from including fs.h in cleancache.h (or one of its predecessors). I agree that that no longer makes sense and it is cleaner as you suggest. Will change.
Thanks, Dan
| |