lkml.org 
[lkml]   [2010]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRE: [PATCH V4 5/8] Cleancache: ext3 hook for cleancache
> > @@ -1349,6 +1350,7 @@ static int ext3_setup_super(struct super
> > } else {
> > ext3_msg(sb, KERN_INFO, "using internal journal");
> > }
> > + sb->cleancache_poolid = cleancache_init_fs(PAGE_SIZE);
>
> Do you really need to pass in the page size? What about just
> "cleancache_init_fs(sb)" rather than exposing the
> "sb->cleancache_poolid"? In other words, what if you want to do
> more/other per-filesystem init at some point?

IIRC, I think I was trying to stay away from including
fs.h in cleancache.h (or one of its predecessors). I
agree that that no longer makes sense and it is cleaner
as you suggest. Will change.

Thanks,
Dan


\
 
 \ /
  Last update: 2010-08-31 03:03    [W:0.029 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site