Messages in this thread | | | Date | Mon, 30 Aug 2010 17:40:42 -0700 (PDT) | From | Dan Magenheimer <> | Subject | RE: [PATCH V4 3/8] Cleancache: core ops functions and configuration |
| |
> > +#ifdef CONFIG_CLEANCACHE > > +#define cleancache_enabled (cleancache_ops.init_fs) > > Pointers can be used in a boolean context, but it would probably be > cleaner to have this evaluate to a proper boolean type. Also I'd > probably go with an all-caps macro name rather than making it look like > a variable.
OK, thanks, will fix.
> > +/* useful stats available in /sys/kernel/mm/cleancache */ > > +static unsigned long succ_gets; > > +static unsigned long failed_gets; > > +static unsigned long puts; > > +static unsigned long flushes; > > I'd probably give these very generic-sounding names some slightly > unique > prefix just to help out people looking at "nm" output or using ctags. > > > +static int get_key(struct inode *inode, struct cleancache_filekey > *key) > > Ditto.
OK, will do.
Thanks for the feedback! Dan
| |