lkml.org 
[lkml]   [2010]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRE: [PATCH 1/3] ARM: Samsung S5P: Move the common Samsung S5P series GPIO level type
    Kyungmin Park wrote:
    >
    > From: Kyungmin Park <kyungmin.park@samsung.com>
    >
    > Samsung S5P series has common level type. It's different from S3C series.
    >
    > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
    > ---
    > arch/arm/plat-samsung/include/plat/gpio-core.h | 6 ++++++
    > 1 files changed, 6 insertions(+), 0 deletions(-)
    >
    > diff --git a/arch/arm/plat-samsung/include/plat/gpio-core.h
    b/arch/arm/plat-
    > samsung/include/plat/gpio-core.h
    > index e358c7d..c8681e0 100644
    > --- a/arch/arm/plat-samsung/include/plat/gpio-core.h
    > +++ b/arch/arm/plat-samsung/include/plat/gpio-core.h
    > @@ -14,6 +14,12 @@
    > #define GPIOCON_OFF (0x00)
    > #define GPIODAT_OFF (0x04)
    >
    > +#define S5P_GPIO_LEVEL_LOW (0x00)
    > +#define S5P_GPIO_LEVEL_HIGH (0x01)
    > +#define S5P_GPIO_EDGE_FALLING (0x02)
    > +#define S5P_GPIO_EDGE_RISING (0x03)
    > +#define S5P_GPIO_EDGE_BOTH (0x04)

    Why should we change the name of definition from S5P_EXTINT_XXX?
    If we use that, we don't need to change other files.

    > +
    > #define con_4bit_shift(__off) ((__off) * 4)
    >
    > /* Define the core gpiolib support functions that the s3c platforms may
    > --

    Thanks.

    Best regards,
    Kgene.
    --
    Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
    SW Solution Development Team, Samsung Electronics Co., Ltd.



    \
     
     \ /
      Last update: 2010-08-30 14:03    [W:0.021 / U:31.424 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site