lkml.org 
[lkml]   [2010]   [Aug]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] flex_array: add helpers to get and put to make pointers easy to use
From
Date
On Tue, 2010-08-03 at 13:55 -0700, David Rientjes wrote:
> On Tue, 3 Aug 2010, Eric Paris wrote:
>
> > Getting and putting arrays of pointers with flex arrays is a PITA. You
> > have to remember to pass &ptr to the _put and you have to do weird and
> > wacky casting to get the ptr back from the _get. Add two functions
> > flex_array_get_ptr() and flex_array_put_ptr() to handle all of the magic.
> >
>
> There's no code currently in the tree that uses the flex array interface,
> so is this something that you've encountered in practice or only by
> inspection? If it's the former, is that code on its way for 2.6.36?

I did decide to use flex_arrays on code intended for .36
http://git.kernel.org/?p=linux/kernel/git/jmorris/security-testing-2.6.git;a=commitdiff;h=6371dcd36f649d9d07823f31400618155a20dde1

> I'm hoping distros aren't creating internal dependencies on this interface
> that could practically be removed from upstream at any time given its lack
> of popularity.

I've got some more patches that I'm looking towards .37 which would use
the _ptr helpers I suggested:

http://marc.info/?l=selinux&m=128086475312322&w=2
http://marc.info/?l=selinux&m=128086558513723&w=2



\
 
 \ /
  Last update: 2010-08-04 00:09    [W:0.062 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site