Messages in this thread Patch in this message | | | Date | Tue, 3 Aug 2010 23:35:17 +0200 (CEST) | From | Julia Lawall <> | Subject | [PATCH 8/9] arch/powerpc/kernel: Drop unnecessary null test |
| |
From: Julia Lawall <julia@diku.dk>
list_for_each_entry binds its first argument to a non-null value, and thus any null test on the value of that argument is superfluous.
The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/)
// <smpl> @@ iterator I; expression x,E,E1,E2; statement S,S1,S2; @@
I(x,...) { <... - if (x != NULL || ...) S ...> } // </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
--- arch/powerpc/kernel/pci_of_scan.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/pci_of_scan.c b/arch/powerpc/kernel/pci_of_scan.c index 6ddb795..62dd363 100644 --- a/arch/powerpc/kernel/pci_of_scan.c +++ b/arch/powerpc/kernel/pci_of_scan.c @@ -336,8 +336,7 @@ static void __devinit __of_scan_bus(struct device_node *node, if (dev->hdr_type == PCI_HEADER_TYPE_BRIDGE || dev->hdr_type == PCI_HEADER_TYPE_CARDBUS) { struct device_node *child = pci_device_to_OF_node(dev); - if (dev) - of_scan_pci_bridge(child, dev); + of_scan_pci_bridge(child, dev); } } }
| |